From 84b45bdb7b77e8fa0f5077a17772c5c0262ace14 Mon Sep 17 00:00:00 2001 From: Jason Parraga Date: Mon, 25 Nov 2024 20:56:09 -0800 Subject: [PATCH] Address comments --- internal/controller/install/armadaserver_controller_test.go | 2 +- internal/controller/install/binoculars_controller_test.go | 2 +- internal/controller/install/common_helpers.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/controller/install/armadaserver_controller_test.go b/internal/controller/install/armadaserver_controller_test.go index e0c0956..bd0319c 100644 --- a/internal/controller/install/armadaserver_controller_test.go +++ b/internal/controller/install/armadaserver_controller_test.go @@ -433,7 +433,7 @@ func TestSchedulerReconciler_createIngress(t *testing.T) { input := v1alpha1.ArmadaServer{ TypeMeta: metav1.TypeMeta{ - Kind: "armadaserver", + Kind: "ArmadaServer", APIVersion: "install.armadaproject.io/v1alpha1", }, ObjectMeta: metav1.ObjectMeta{ diff --git a/internal/controller/install/binoculars_controller_test.go b/internal/controller/install/binoculars_controller_test.go index 2e6f5d3..651c984 100644 --- a/internal/controller/install/binoculars_controller_test.go +++ b/internal/controller/install/binoculars_controller_test.go @@ -481,7 +481,7 @@ func TestSchedulerReconciler_createBinocularsIngress(t *testing.T) { input := v1alpha1.Binoculars{ TypeMeta: metav1.TypeMeta{ - Kind: "binoculars", + Kind: "Binoculars", APIVersion: "install.armadaproject.io/v1alpha1", }, ObjectMeta: metav1.ObjectMeta{ diff --git a/internal/controller/install/common_helpers.go b/internal/controller/install/common_helpers.go index 5d9e0ff..efc353f 100644 --- a/internal/controller/install/common_helpers.go +++ b/internal/controller/install/common_helpers.go @@ -317,7 +317,7 @@ func ExtractPulsarConfig(config runtime.RawExtension) (PulsarConfig, error) { if err != nil { return PulsarConfig{}, err } - return asConfig.Pulsar, err + return asConfig.Pulsar, nil } // GetServerScheme returns the URI scheme for the grpc server