Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make armadactl kube accept just jobId #130

Open
sync-by-unito bot opened this issue Apr 7, 2023 · 1 comment
Open

Make armadactl kube accept just jobId #130

sync-by-unito bot opened this issue Apr 7, 2023 · 1 comment

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 7, 2023

From jobId we can determine jobset/queue quite simply.

This makes it a lot easier to use this command, rather than having to have a command like:

armadactl kube logs --queue queueA --jobSet some-job-set --jobId <job_id>

It can be as simple as

armadactl kube logs <job_id>

┆Issue is synchronized with this Jira Task by Unito

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 7, 2023

➤ Stefan Novakovic commented:

JamesMurkin is this really something that is doable? My understanding is that JobID is strictly identified with queue and job set, in other words it is possible to have same JobID value with different queue/jobset pairs.

The current implementation further supports this notion, as it retrieves information about specific job set first:
https://github.com/G-Research/armada/blob/dbe530525cc9dd6fe2ad29b06d4c56fb6d5960f5/cmd/armadactl/cmd/kube.go#L53-L57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants