From 28414f6d8813ea983f788ae91976efafe7d2e3d7 Mon Sep 17 00:00:00 2001 From: Foretack Date: Sun, 19 Mar 2023 12:15:56 +0100 Subject: [PATCH 1/3] Add a method to set HttpClient timeout --- FeedReader/Helpers.cs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/FeedReader/Helpers.cs b/FeedReader/Helpers.cs index ad71e92..5dcbbfb 100644 --- a/FeedReader/Helpers.cs +++ b/FeedReader/Helpers.cs @@ -30,6 +30,16 @@ public static class Helpers } ); +#if NETSTANDARD1_1_OR_GREATER || NETCOREAPP1_0_OR_GREATER + /// + /// Set a timeout for http calls + /// + public static void SetTimeout(TimeSpan timeout) + { + _httpClient.Timeout = timeout; + } +#endif + /// /// Download the content from an url /// From 2d56d72539890a93817d3804719b255472e5e975 Mon Sep 17 00:00:00 2001 From: Foretack Date: Sun, 19 Mar 2023 12:21:01 +0100 Subject: [PATCH 2/3] Add a method to set HttpClient timeout --- FeedReader/FeedReader.cs | 11 +++++++++++ FeedReader/Helpers.cs | 5 +---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/FeedReader/FeedReader.cs b/FeedReader/FeedReader.cs index 3d594e4..bec0f07 100644 --- a/FeedReader/FeedReader.cs +++ b/FeedReader/FeedReader.cs @@ -3,6 +3,7 @@ using System; using System.Collections.Generic; using System.Linq; + using System.Net.Http; using System.Threading; using System.Threading.Tasks; using Parser; @@ -21,6 +22,16 @@ /// public static class FeedReader { +#if NETSTANDARD1_1_OR_GREATER || NETCOREAPP1_0_OR_GREATER + /// + /// Set a timeout for reading feeds + /// + public static void SetTimeout(TimeSpan timeout) + { + Helpers.SetTimeout(timeout); + } +#endif + /// /// gets a url (with or without http) and returns the full url /// diff --git a/FeedReader/Helpers.cs b/FeedReader/Helpers.cs index 5dcbbfb..a8603a1 100644 --- a/FeedReader/Helpers.cs +++ b/FeedReader/Helpers.cs @@ -31,10 +31,7 @@ public static class Helpers ); #if NETSTANDARD1_1_OR_GREATER || NETCOREAPP1_0_OR_GREATER - /// - /// Set a timeout for http calls - /// - public static void SetTimeout(TimeSpan timeout) + internal static void SetTimeout(TimeSpan timeout) { _httpClient.Timeout = timeout; } From fce913b1109e6e09516fb1f26edbb9892d5bd1b1 Mon Sep 17 00:00:00 2001 From: Foretack Date: Sun, 19 Mar 2023 12:26:59 +0100 Subject: [PATCH 3/3] Add NET45 --- FeedReader/FeedReader.cs | 2 +- FeedReader/Helpers.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/FeedReader/FeedReader.cs b/FeedReader/FeedReader.cs index bec0f07..4d38ac4 100644 --- a/FeedReader/FeedReader.cs +++ b/FeedReader/FeedReader.cs @@ -22,7 +22,7 @@ /// public static class FeedReader { -#if NETSTANDARD1_1_OR_GREATER || NETCOREAPP1_0_OR_GREATER +#if NETSTANDARD1_1_OR_GREATER || NETCOREAPP1_0_OR_GREATER || NET45_OR_GREATER /// /// Set a timeout for reading feeds /// diff --git a/FeedReader/Helpers.cs b/FeedReader/Helpers.cs index a8603a1..0d05899 100644 --- a/FeedReader/Helpers.cs +++ b/FeedReader/Helpers.cs @@ -30,7 +30,7 @@ public static class Helpers } ); -#if NETSTANDARD1_1_OR_GREATER || NETCOREAPP1_0_OR_GREATER +#if NETSTANDARD1_1_OR_GREATER || NETCOREAPP1_0_OR_GREATER || NET45_OR_GREATER internal static void SetTimeout(TimeSpan timeout) { _httpClient.Timeout = timeout;