Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player ID not parsed correctly in cfbd_json_py.players.get_cfbd_player_season_stats() #51

Closed
erikhall6373 opened this issue Aug 29, 2024 · 1 comment · Fixed by #52
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@erikhall6373
Copy link

Hi I've been recently using this package for a Heisman trophy model, and have found it a lot more accessible than the regular cfbd package.

Caught a bug I believe in the code for the get_cfbd_player_season_stats function.

For passing statistics player_id appropriately commented out,

image

But not for rushing statistics,

image

I personally like having player_id available, and I was playing around with the code to get it to work.

I figured this kind of patch would work for the function,

image

Thanks for all that you do in this package!

@armstjc armstjc self-assigned this Aug 29, 2024
@armstjc armstjc added bug Something isn't working good first issue Good for newcomers labels Aug 29, 2024
@armstjc armstjc changed the title Player ID not in Index for get_cfbd_player_season_stats Player ID not parsed correctly in cfbd_json_py.players.get_cfbd_player_season_stats() Aug 29, 2024
@armstjc
Copy link
Owner

armstjc commented Aug 29, 2024

Issue has been identified, update will be pushed as soon as I can validate that the fix has been implemented corectly.

Thanks for the bug find!

armstjc added a commit that referenced this issue Aug 29, 2024
- Fixed an issue raised in #51 where the `[player_id]` column would be entirely blank in `cfbd_json_py.players.get_cfbd_player_season_stats()`.
- Updated the package version to `0.2.3`.
@armstjc armstjc linked a pull request Aug 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants