Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crashlytics): Test Crash Implemented #951

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AhsanAyaz
Copy link

@AhsanAyaz AhsanAyaz commented Nov 19, 2018

Implemented Firebase's test crash (force crash) implementation which is handy for crashlytics.
I think I'd be the happiest person if this gets merged. 😄

Fixes #920

@AhsanAyaz AhsanAyaz force-pushed the test-crash-crashlytics branch from 2f2dea0 to 085788e Compare November 19, 2018 11:15
@amirhmoradi
Copy link

@AhsanAyaz Thanks for implmenting the testCrash method. It saves me lots of time and lets me skip adding other cordova plugins to my project.
I think you shall fix the added/modified whitespaces in your PR, so that you do not modify files/lines not relevant to your PR.

The CI Build failures are fixed in the PR #958 , the reason is mainly about the environment vars/deps.

It would be great if someone with write access could merge this PR once it gets cleaned of whitespaces 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants