-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Shifting to NextJS #79
base: next-app
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @arpitghura, you have requested a new branch for the Next.JS transfer. I think this is a great idea but I do not have permission to make a new branch. Could you make a new branch for this? |
Yeah sure 😊 |
Great going @zemetskiym, I have seen you have moved some part of the web app to Nextjs like index page and about page, but you need to do some more changes to the code so that it will work seamlessly. |
components/Navbar.js
Outdated
<div className={styles.githubIcon}> | ||
<a href="https://github.com/arpitghura/typing-test" className={styles.navItemLink}><i className='bx bx-sm bxl-github'></i></a> | ||
</div> | ||
<button onclick="toggleLightDarkMode()" className={styles.darkBtn}>Dark Mode</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<button onclick="toggleLightDarkMode()" className={styles.darkBtn}>Dark Mode</button> | |
<button onClick="toggleLightDarkMode()" className={styles.darkBtn}>Dark Mode</button> |
This can be done by changing the base of the PR since it is pointing to main branch, and we are changing it to |
Is the PR ready for review or some work is pending? |
There are a few areas that need some attention before it can be merged. I am working on adding functionality to the typing test and profile section. Let me know if you have any questions or concerns. |
Hi @arpitghura, I hope this message finds you well. I have made progress in this pull request draft but I have come across a challenge in converting the previous Javascript for the Practice page into a format that is compatible with Next.js. I would greatly appreciate any guidance or assistance you could provide in this matter. I believe that your expertise and experience would be invaluable in helping me to resolve this issue. Thank you for your time and support. I look forward to hearing from you soon. Best regards, |
Yeah Sure, it would be helpful for me also. For Further Communication join our discord server here |
In order to switch to NextJS, I am creating a new application and transferring the files over, working out bugs along the way. Let me know if you have any suggestions, questions, or concerns as progress is made.