Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Shifting to NextJS #79

Draft
wants to merge 23 commits into
base: next-app
Choose a base branch
from
Draft

Conversation

zemetskiym
Copy link
Contributor

SPA provides a better user experience & Fast loading of webpages.

NextJS is good option for the SSR and SPA
We can keep the current styling and markup maybe tweek something and shift this application to next and it would provide us >with some of the great features of NextJS.

Also we will use containers since this is a production application.

In order to switch to NextJS, I am creating a new application and transferring the files over, working out bugs along the way. Let me know if you have any suggestions, questions, or concerns as progress is made.

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
typing-test ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 4:04AM (UTC)

@zemetskiym
Copy link
Contributor Author

Hey @arpitghura, you have requested a new branch for the Next.JS transfer. I think this is a great idea but I do not have permission to make a new branch. Could you make a new branch for this?

@arpitghura arpitghura marked this pull request as ready for review January 19, 2023 20:14
@arpitghura arpitghura marked this pull request as draft January 19, 2023 20:15
@arpitghura
Copy link
Owner

Hey @arpitghura, you have requested a new branch for the Next.JS transfer. I think this is a great idea but I do not have permission to make a new branch. Could you make a new branch for this?

Yeah sure 😊

@arpitghura
Copy link
Owner

Great going @zemetskiym, I have seen you have moved some part of the web app to Nextjs like index page and about page, but you need to do some more changes to the code so that it will work seamlessly.

@arpitghura arpitghura linked an issue Jan 27, 2023 that may be closed by this pull request
.gitignore Outdated Show resolved Hide resolved
<div className={styles.githubIcon}>
<a href="https://github.com/arpitghura/typing-test" className={styles.navItemLink}><i className='bx bx-sm bxl-github'></i></a>
</div>
<button onclick="toggleLightDarkMode()" className={styles.darkBtn}>Dark Mode</button>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button onclick="toggleLightDarkMode()" className={styles.darkBtn}>Dark Mode</button>
<button onClick="toggleLightDarkMode()" className={styles.darkBtn}>Dark Mode</button>

pages/index.js Outdated Show resolved Hide resolved
@arpitghura
Copy link
Owner

arpitghura commented Jan 30, 2023

Hey @arpitghura, you have requested a new branch for the Next.JS transfer. I think this is a great idea, but I do not have permission to make a new branch. Could you make a new branch for this?

This can be done by changing the base of the PR since it is pointing to main branch, and we are changing it to next-app. This may cause some conflicts which we will fix.

@arpitghura arpitghura changed the base branch from main to next-app January 30, 2023 10:56
@arpitghura
Copy link
Owner

Is the PR ready for review or some work is pending?

@zemetskiym
Copy link
Contributor Author

There are a few areas that need some attention before it can be merged. I am working on adding functionality to the typing test and profile section. Let me know if you have any questions or concerns.

@zemetskiym
Copy link
Contributor Author

Hi @arpitghura,

I hope this message finds you well. I have made progress in this pull request draft but I have come across a challenge in converting the previous Javascript for the Practice page into a format that is compatible with Next.js.

I would greatly appreciate any guidance or assistance you could provide in this matter. I believe that your expertise and experience would be invaluable in helping me to resolve this issue.

Thank you for your time and support. I look forward to hearing from you soon.

Best regards,
Matthew Zemetskiy

@arpitghura
Copy link
Owner

Hi @arpitghura,

I hope this message finds you well. I have made progress in this pull request draft but I have come across a challenge in converting the previous Javascript for the Practice page into a format that is compatible with Next.js.

I would greatly appreciate any guidance or assistance you could provide in this matter. I believe that your expertise and experience would be invaluable in helping me to resolve this issue.

Thank you for your time and support. I look forward to hearing from you soon.

Best regards, Matthew Zemetskiy

Yeah Sure, it would be helpful for me also. For Further Communication join our discord server here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shifting to NextJS
2 participants