Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis connection doesn't work with predis #18

Open
WouterFlorijn opened this issue Apr 29, 2021 · 0 comments
Open

Redis connection doesn't work with predis #18

WouterFlorijn opened this issue Apr 29, 2021 · 0 comments

Comments

@WouterFlorijn
Copy link

It seems this package is calling methods that don't exist on the Redis facade, making it unusable with Redis:

Error thrown with message "Call to undefined method Illuminate\Support\Facades\Redis::pconnect()"

Stacktrace:
#35 Error in C:\wamp\www\dyme-api\src\vendor\promphp\prometheus_client_php\src\Prometheus\Storage\Redis.php:186
#34 Prometheus\Storage\Redis:connectToServer in C:\wamp\www\dyme-api\src\vendor\promphp\prometheus_client_php\src\Prometheus\Storage\Redis.php:165
#33 Prometheus\Storage\Redis:ensureOpenConnection in C:\wamp\www\dyme-api\src\vendor\promphp\prometheus_client_php\src\Prometheus\Storage\Redis.php:247
#32 Prometheus\Storage\Redis:updateGauge in C:\wamp\www\dyme-api\src\vendor\promphp\prometheus_client_php\src\Prometheus\Gauge.php:23
#31 Prometheus\Gauge:set in C:\wamp\www\dyme-api\src\vendor\promphp\prometheus_client_php\src\Prometheus\CollectorRegistry.php:286
#30 Prometheus\CollectorRegistry:registerDefaultMetrics in C:\wamp\www\dyme-api\src\vendor\promphp\prometheus_client_php\src\Prometheus\CollectorRegistry.php:54
#29 Prometheus\CollectorRegistry:__construct in C:\wamp\www\dyme-api\src\vendor\arquivei\laravel-prometheus-exporter\src\PrometheusServiceProvider.php:35
#28 Arquivei\LaravelPrometheusExporter\PrometheusServiceProvider:Arquivei\LaravelPrometheusExporter\{closure} in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Container\Container.php:805
#27 Illuminate\Container\Container:build in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Container\Container.php:691
#26 Illuminate\Container\Container:resolve in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\Application.php:796
#25 Illuminate\Foundation\Application:resolve in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Container\Container.php:637
#24 Illuminate\Container\Container:make in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\Application.php:781
#23 Illuminate\Foundation\Application:make in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\helpers.php:119
#22 app in C:\wamp\www\dyme-api\src\vendor\arquivei\laravel-prometheus-exporter\src\PrometheusLaravelRouteMiddleware.php:30
#21 Arquivei\LaravelPrometheusExporter\PrometheusLaravelRouteMiddleware:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#20 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\app\Http\Middleware\AddHeaders.php:12
#19 App\Http\Middleware\AddHeaders:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#18 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\vendor\benconstable\laravel-localize-middleware\src\Localize\Http\Middleware\Localize.php:58
#17 BenConstable\Localize\Http\Middleware\Localize:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#16 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\vendor\fruitcake\laravel-cors\src\HandleCors.php:38
#15 Fruitcake\Cors\HandleCors:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#14 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\vendor\fideloper\proxy\src\TrustProxies.php:57
#13 Fideloper\Proxy\TrustProxies:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#12 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php:21
#11 Illuminate\Foundation\Http\Middleware\TransformsRequest:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#10 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php:21
#9 Illuminate\Foundation\Http\Middleware\TransformsRequest:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#8 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ValidatePostSize.php:27
#7 Illuminate\Foundation\Http\Middleware\ValidatePostSize:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#6 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode.php:63
#5 Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode:handle in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:167
#4 Illuminate\Pipeline\Pipeline:Illuminate\Pipeline\{closure} in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:103
#3 Illuminate\Pipeline\Pipeline:then in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php:140
#2 Illuminate\Foundation\Http\Kernel:sendRequestThroughRouter in C:\wamp\www\dyme-api\src\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php:109
#1 Illuminate\Foundation\Http\Kernel:handle in C:\wamp\www\dyme-api\src\public\index.php:55
#0 require_once in C:\wamp\www\dyme-api\src\server.php:21

If I comment out this call, it falls back to connect(...), which also doesn't exist.

I'm not sure if it does work with phpredis, but I think the package shouldn't rely on a specific redis package. Therefore it should rely only on facade methods that always exist, or it should include its own redis connection and not rely on the facade at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant