Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility check and testing for node.js 22 #49

Open
ioBroker-Bot opened this issue Sep 28, 2024 · 6 comments
Open

Compatibility check and testing for node.js 22 #49

ioBroker-Bot opened this issue Sep 28, 2024 · 6 comments
Labels

Comments

@ioBroker-Bot
Copy link

Notification from ioBroker Check and Service Bot

Dear Adapter developer,

Node.js 22 will become the official node.js LTS release October 2024 - see node-releases

So please check your adapter with Node.js 22.

Please add node.js 22 to the adapter testing matrix which is executed on commits. This check is normally controlled by workflow located at .github/workflows/test-and-release.yml. The recommended testmatrix is [18.x, 20.x, 22.x] now. It's ok to test node.js 20.x and 22.x only if there are any technical reasons (i.e. requirements caused by dependencies) to do so.

In any case please set the 'engines' clause in package.json according to the minimum node version used at testing. Please also do this if the adapter is not able to work with certain Node.js versions, so that ioBroker can prevent users from installing the adapter if not compatible. If you detect any incompatibility with node.js 22 please try to fix it and / or let us know if the problem seems to be located at core components.

Please close the issue after you checked it.

Feel free to contact me (@ioBroker-Bot) if you have any questions.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@mcm1957 for evidence

Note: If you added node 22 tests already, simply close this issue.

@mcm1957
Copy link

mcm1957 commented Sep 28, 2024

nodeJs 22 tests seem to be missing

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 29, 2024
@mcm1957
Copy link

mcm1957 commented Oct 29, 2024

not stale as still open

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added Stale and removed Stale labels Nov 29, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 30, 2024
@ioBroker-Bot
Copy link
Author

This issue should not be considered stale.
Please process and close it if completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants