Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul the integration of the broker edition form within OpenShift #293

Open
2 tasks
lavocatt opened this issue Sep 18, 2024 · 4 comments · Fixed by #319
Open
2 tasks

Overhaul the integration of the broker edition form within OpenShift #293

lavocatt opened this issue Sep 18, 2024 · 4 comments · Fixed by #319
Assignees
Labels
M tshirt size
Milestone

Comments

@lavocatt
Copy link
Collaborator

lavocatt commented Sep 18, 2024

Very similar to #292 this issue has for objective to make sure that every button a user can click onto (except OLM) to edit a broker goes to our custom form.

Also in the search view:
image

How to proceed:

  • Identify if a hook exists to support this use case, it might not be and if it isn't we might need to either rethink our approach or to come up with a clear usecase for the openshift console dynamic plugin folks and work conjointly with them to resolve that
  • Use the hook that has been identified or has been implemented by the dynamic plugin sdk team.
@lavocatt
Copy link
Collaborator Author

There a few unknowns for this one, that's the reason I'm setting it to the M size. Maybe it'll work by default once #292 is done but it's too soon to be said.

@Msarawan Msarawan self-assigned this Sep 26, 2024
Msarawan added a commit to Msarawan/activemq-artemis-self-provisioning-plugin that referenced this issue Oct 1, 2024
…Shift

Added integration of our custom broker-edition form within OpenShift. It allows users
to edit brokers from multiple locations, such as through the OpenShift search results
or from the Installed Operators section.
Users can now utilize our custom broker-edition form to edit brokers in both instances.
lavocatt pushed a commit to Msarawan/activemq-artemis-self-provisioning-plugin that referenced this issue Oct 3, 2024
…Shift

Added integration of our custom broker-edition form within OpenShift. It allows users
to edit brokers from multiple locations, such as through the OpenShift search results
or from the Installed Operators section.
Users can now utilize our custom broker-edition form to edit brokers in both instances.
lavocatt pushed a commit that referenced this issue Oct 3, 2024
Added integration of our custom broker-edition form within OpenShift. It allows users
to edit brokers from multiple locations, such as through the OpenShift search results
or from the Installed Operators section.
Users can now utilize our custom broker-edition form to edit brokers in both instances.
@lavocatt
Copy link
Collaborator Author

lavocatt commented Oct 3, 2024

One possible way to achieve this is to filter the Edit ActiveMQArtemis action using this extension:

image

And to add a new Edit Broker action using this extension:

image

It is unknown at this point if this strategy would work or not.

Msarawan added a commit to Msarawan/activemq-artemis-self-provisioning-plugin that referenced this issue Oct 25, 2024
…m within OpenShift

Added integration of our custom broker-edition form within OpenShift. It allows users
to edit brokers from multiple locations, such as through the OpenShift search results
or from the Installed Operators section.
Users can now utilize our custom broker-edition form to edit brokers in both the instances.
and also updated redirect paths to points to the previous location.
@Msarawan Msarawan removed the blocked label Oct 25, 2024
gaohoward pushed a commit that referenced this issue Oct 25, 2024
…nShift

Added integration of our custom broker-edition form within OpenShift. It allows users
to edit brokers from multiple locations, such as through the OpenShift search results
or from the Installed Operators section.
Users can now utilize our custom broker-edition form to edit brokers in both the instances.
and also updated redirect paths to points to the previous location.
@lavocatt lavocatt reopened this Oct 28, 2024
@lavocatt
Copy link
Collaborator Author

There's an issue with the current implementation. It allows for having the edition to show up correctly, but at the cost of entirely overloading the standard details page with the edition form:

When you click on the name of a broker there:

image

I'll open
image

Which is wrong, it shouldn't. We need to revert the PR that got merged 3 days ago, sorry about that @Msarawan

@Msarawan
Copy link
Collaborator

There's an issue with the current implementation. It allows for having the edition to show up correctly, but at the cost of entirely overloading the standard details page with the edition form:

When you click on the name of a broker there:

image

I'll open image

Which is wrong, it shouldn't. We need to revert the PR that got merged 3 days ago, sorry about that @Msarawan

Thank you Thomas, for catching that! I had tested the edit-broker page functionality at both the search and installed operator instances. Last time, since the redirect wasn’t working as expected, I fixed it. and added custom edit-broker page by adding the url's in the console-extension file as recommended by the SDK team. It appeared to be resolved, but I hadn’t noticed the incorrect redirect when clicking on the names—thank you for identifying that oversight. I’ll work on fixing it now.

lavocatt added a commit to lavocatt/activemq-artemis-self-provisioning-plugin that referenced this issue Oct 31, 2024
…tion form within OpenShift"

This reverts commit f13f127.
lavocatt added a commit to lavocatt/activemq-artemis-self-provisioning-plugin that referenced this issue Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M tshirt size
Projects
None yet
2 participants