-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul the integration of the broker edition form within OpenShift #293
Comments
There a few unknowns for this one, that's the reason I'm setting it to the M size. Maybe it'll work by default once #292 is done but it's too soon to be said. |
…Shift Added integration of our custom broker-edition form within OpenShift. It allows users to edit brokers from multiple locations, such as through the OpenShift search results or from the Installed Operators section. Users can now utilize our custom broker-edition form to edit brokers in both instances.
…Shift Added integration of our custom broker-edition form within OpenShift. It allows users to edit brokers from multiple locations, such as through the OpenShift search results or from the Installed Operators section. Users can now utilize our custom broker-edition form to edit brokers in both instances.
Added integration of our custom broker-edition form within OpenShift. It allows users to edit brokers from multiple locations, such as through the OpenShift search results or from the Installed Operators section. Users can now utilize our custom broker-edition form to edit brokers in both instances.
…m within OpenShift Added integration of our custom broker-edition form within OpenShift. It allows users to edit brokers from multiple locations, such as through the OpenShift search results or from the Installed Operators section. Users can now utilize our custom broker-edition form to edit brokers in both the instances. and also updated redirect paths to points to the previous location.
…nShift Added integration of our custom broker-edition form within OpenShift. It allows users to edit brokers from multiple locations, such as through the OpenShift search results or from the Installed Operators section. Users can now utilize our custom broker-edition form to edit brokers in both the instances. and also updated redirect paths to points to the previous location.
There's an issue with the current implementation. It allows for having the edition to show up correctly, but at the cost of entirely overloading the standard details page with the edition form: When you click on the name of a broker there: Which is wrong, it shouldn't. We need to revert the PR that got merged 3 days ago, sorry about that @Msarawan |
Thank you Thomas, for catching that! I had tested the edit-broker page functionality at both the search and installed operator instances. Last time, since the redirect wasn’t working as expected, I fixed it. and added custom edit-broker page by adding the url's in the console-extension file as recommended by the SDK team. It appeared to be resolved, but I hadn’t noticed the incorrect redirect when clicking on the names—thank you for identifying that oversight. I’ll work on fixing it now. |
…tion form within OpenShift" This reverts commit f13f127.
Very similar to #292 this issue has for objective to make sure that every button a user can click onto (except OLM) to edit a broker goes to our custom form.
Also in the search view:
How to proceed:
The text was updated successfully, but these errors were encountered: