Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confirmation] Would you like to add the transform option? #6

Closed
macocci7 opened this issue Aug 8, 2024 · 2 comments
Closed

[Confirmation] Would you like to add the transform option? #6

macocci7 opened this issue Aug 8, 2024 · 2 comments

Comments

@macocci7
Copy link
Contributor

macocci7 commented Aug 8, 2024

@ProjektGopher I'm going to add transform option to file-selector-prompt.
I've already implemented it and opened a PR in my file-selector-prompt repository.
I'll merge the PR and release it after the new realease of laravel/promts (probably next week).

If you'd like to add transform option, I'll implement it in fileselector in this repository and update the document.
Please tell me your opinion.

@ProjektGopher
Copy link
Member

I think that makes sense to include. We'll have to wait for the next release of prompts (as you pointed out), then we'll bump our dependency, but we'll also have to implement all those changes to the Prompt abstract class in the original transform PR you linked in our PatchedPrompt shim.

@macocci7
Copy link
Contributor Author

macocci7 commented Aug 8, 2024

OK!
I'll implement transform option and apply all those changes to the Prompt abstract class to the PatchedPrompt shim later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants