Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll-frame-loading class isn't added to body in webkit browsers #28

Open
mrlosh opened this issue Oct 26, 2015 · 2 comments
Open

scroll-frame-loading class isn't added to body in webkit browsers #28

mrlosh opened this issue Oct 26, 2015 · 2 comments
Labels

Comments

@mrlosh
Copy link

mrlosh commented Oct 26, 2015

scroll-frame-loading class gets added in firefox, but not chrome or safari.

@sumnone
Copy link

sumnone commented Oct 27, 2015

I believe I have have the same issue. I think scroll-frame-loading gets added, but it's on the parent... So, when you click a scroll-frame link, it immediately pops open the blank iframe and waits for that to load with no visible indicator for the user... Is that what you're seeing?

@mrlosh
Copy link
Author

mrlosh commented Oct 27, 2015

I did a little more digging and it looks like the scroll-frame-loading class does get added in all browsers to parent body tag, but it gets removed instantly in chrome and safari because this function iframe.onload on line 73 of scroll-frame.js doesn't return anything in those browsers. My "fix" (a hack really) was to comment out the iframe.onload function, then put another script inside the iframe that tells its parent to remove the scroll-frame-loading class once it's loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants