Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of rug plot to plot_dist #72

Open
imperorrp opened this issue Jul 18, 2024 · 1 comment
Open

Addition of rug plot to plot_dist #72

imperorrp opened this issue Jul 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@imperorrp
Copy link
Collaborator

Legacy Arviz' plot_dist/plot_kde support rug plot visualization for the density, different from the rug plots for divergences that trace_plot and trace_plot_dist have already. Should this functionality be added to plot_dist with a top level argument to toggle whether to generate it or not?

As an added benefit to other plots that call plot_dist internally, like plot_ppc, the rug plot for the observed_data values could be generated by simply passing rug=True to the plot_dist call made for observed data kde plotting. So the observed_rug plot generation logic could be moved to plot_dist.

@imperorrp imperorrp added the enhancement New feature or request label Jul 18, 2024
@OriolAbril
Copy link
Member

Sounds good, it could also be used for the left column of plot_trace_dist, but should be off by default in plot_dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants