From ecd708f66bf188d58ad6dde6b32bcc05995136c8 Mon Sep 17 00:00:00 2001 From: pad Date: Fri, 19 Apr 2024 20:11:43 +0200 Subject: [PATCH] more --- .github/workflows/build-and-test.jsonnet | 10 +++++----- .github/workflows/build-and-test.yml | 1 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-and-test.jsonnet b/.github/workflows/build-and-test.jsonnet index 2b123ca..11d4b37 100644 --- a/.github/workflows/build-and-test.jsonnet +++ b/.github/workflows/build-and-test.jsonnet @@ -22,12 +22,12 @@ local job = { //TODO: 'windows-latest' ], 'ocaml-compiler': [ - // Version that I ported ocamlrun to plan9 (need stdcompat - // so we can use |> and bytes type without issues) + // Old OCaml version where I ported ocamlrun to plan9 + // This needs stdcompat so we can use |> and bytes type without issues. + // The |> operator was introduced in 4.02.0, that we could add in + // the matrix, but stdcompat does not compile with it. '3.10.0', - // Old version with |> builtin - '4.02.1', - // first version with valid ocamlformat + // First OCaml version with a working ocamlformat OPAM package '4.04.1', //TODO: Ideally 4.14.1 and ocaml latest (5.2.0) ], diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 5c76c37..8294057 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -22,7 +22,6 @@ jobs: matrix: ocaml-compiler: - 3.10.0 - - 4.02.1 - 4.04.1 os: - ubuntu-latest