Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion about Morph.json #36

Open
Keebsz opened this issue Aug 26, 2020 · 10 comments
Open

Suggestion about Morph.json #36

Keebsz opened this issue Aug 26, 2020 · 10 comments
Labels
enhancement Feature request, general feedback, etc help wanted Won't do (but maybe you can! Ask to self-assign) interaction Requires other mod / outside factor to reproduce

Comments

@Keebsz
Copy link

Keebsz commented Aug 26, 2020

I recently made a morphs.json config for the modpack I am developing. I was wondering, with all the mobs I configured from different mods, maybe you can take the config and implement it into the mod so other people do not have to. If you are wondering what mods I worked on, I worked on...
Animania
Better Animals Plus
The Aether
Aether II
Ice and Fire
Mo Creatures
Mowziemobs
Futuremc
Vampirism
Tinker Construct
Gravestone mod - extended
Howling moon

If you don't want to implement it, may I upload the file I made to curse forge so other people can download it when they use your mod?

@James103
Copy link

Do you have the exact morphs.json available to upload here?

See mchorse#243

@Keebsz
Copy link
Author

Keebsz commented Aug 26, 2020

morph.zip
I had to make it a zip file since I wasn't allowed to send the .json

@asanetargoss asanetargoss added enhancement Feature request, general feedback, etc interaction Requires other mod / outside factor to reproduce labels Aug 27, 2020
@asanetargoss
Copy link
Owner

Thanks for opening an issue for this.

First and foremost, Changeling is licensed under the MIT license, which is very flexible in what you are allowed to do. If you were redistributing the mod itself or the source code, I would recommend learning more about the license. But since you're not doing either of those things, you're pretty much free to do whatever you want, including uploading your configuration to Curseforge, no permission required.

I will look at the morphs JSON later and decide whether it's a good fit for the mod or not.

@asanetargoss
Copy link
Owner

The JSON looks fine. Would you be alright with formatting it (Such as with: https://jsonformatter.curiousconcept.com/ ), adding it to the existing morphs.json, and opening a pull request?

@Keebsz
Copy link
Author

Keebsz commented Aug 30, 2020

Sure. In the time doing this I also made changeling compatible for The Twilight Forest. May I also add that in?
Another thing, I just want to let you know that some mobs glitch the game out.
With the Ice and Fire mod, the mob id for glitched out mobs are:
iceandfire:seaserpent

For the Aether mod:
aether_legacy:swet

@asanetargoss asanetargoss added bug Non-fatal error or unexpected behavior info needed Won't do (unless more information given) multi Contains multiple asks. Most asks in multis are Won't do labels Aug 31, 2020
@asanetargoss
Copy link
Owner

Feel free to add or change anything. I will be able to review it in the pull request.

How are these mobs "glitching out" exactly?

@asanetargoss
Copy link
Owner

I just did a large pull from upstream which made changes to vanilla mob configs.

I see this issue has not had activity. These configs likely won't work on 1.10, due to the mob ID overhaul between 1.10 and 1.11. For that reason, I recommend a pull request against changeling-1.11

If it is better, I or someone else could add @Kevini-i 's configs, however they would have to give permission first.

@Keebsz
Copy link
Author

Keebsz commented Oct 19, 2020

@asanetargoss you have my permission to do whatever you like to the config. The only thing I didn't do was specify what type of morph was a mob. For the Aether, I believe one of the bosses wasn't created since I never got around to it. There were a few mobs I did blacklist because it caused a glitch

The blacklist:
"iceandfire:seaserpent",
"aether_legacy:swet",
"betternether:firefly",
"iceandfire:firedragon"
"iceandfire:icedragon"

Everything pretty much crashed you besides the iceandfire dragons. they were just buggy in terms in didn't move right when you were to fly.

I am going to open a pull request now. Sorry for the long wait.

@kernbruv
Copy link

kernbruv commented Dec 9, 2020

so just replace the morphs.json and its good to go?

@asanetargoss
Copy link
Owner

so just replace the morphs.json and its good to go?

What are you trying to do?

@asanetargoss asanetargoss added help wanted Won't do (but maybe you can! Ask to self-assign) and removed info needed Won't do (unless more information given) bug Non-fatal error or unexpected behavior multi Contains multiple asks. Most asks in multis are Won't do labels Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, general feedback, etc help wanted Won't do (but maybe you can! Ask to self-assign) interaction Requires other mod / outside factor to reproduce
Projects
None yet
Development

No branches or pull requests

4 participants