-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion about Morph.json #36
Comments
Do you have the exact morphs.json available to upload here? See mchorse#243 |
morph.zip |
Thanks for opening an issue for this. First and foremost, Changeling is licensed under the MIT license, which is very flexible in what you are allowed to do. If you were redistributing the mod itself or the source code, I would recommend learning more about the license. But since you're not doing either of those things, you're pretty much free to do whatever you want, including uploading your configuration to Curseforge, no permission required. I will look at the morphs JSON later and decide whether it's a good fit for the mod or not. |
The JSON looks fine. Would you be alright with formatting it (Such as with: https://jsonformatter.curiousconcept.com/ ), adding it to the existing morphs.json, and opening a pull request? |
Sure. In the time doing this I also made changeling compatible for The Twilight Forest. May I also add that in? For the Aether mod: |
Feel free to add or change anything. I will be able to review it in the pull request. How are these mobs "glitching out" exactly? |
I just did a large pull from upstream which made changes to vanilla mob configs. I see this issue has not had activity. These configs likely won't work on 1.10, due to the mob ID overhaul between 1.10 and 1.11. For that reason, I recommend a pull request against If it is better, I or someone else could add @Kevini-i 's configs, however they would have to give permission first. |
@asanetargoss you have my permission to do whatever you like to the config. The only thing I didn't do was specify what type of morph was a mob. For the Aether, I believe one of the bosses wasn't created since I never got around to it. There were a few mobs I did blacklist because it caused a glitch The blacklist: Everything pretty much crashed you besides the iceandfire dragons. they were just buggy in terms in didn't move right when you were to fly. I am going to open a pull request now. Sorry for the long wait. |
so just replace the morphs.json and its good to go? |
What are you trying to do? |
I recently made a morphs.json config for the modpack I am developing. I was wondering, with all the mobs I configured from different mods, maybe you can take the config and implement it into the mod so other people do not have to. If you are wondering what mods I worked on, I worked on...
Animania
Better Animals Plus
The Aether
Aether II
Ice and Fire
Mo Creatures
Mowziemobs
Futuremc
Vampirism
Tinker Construct
Gravestone mod - extended
Howling moon
If you don't want to implement it, may I upload the file I made to curse forge so other people can download it when they use your mod?
The text was updated successfully, but these errors were encountered: