Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not passing in minimal build environment #99

Open
aerostitch opened this issue Apr 27, 2020 · 2 comments
Open

Tests not passing in minimal build environment #99

aerostitch opened this issue Apr 27, 2020 · 2 comments

Comments

@aerostitch
Copy link
Contributor

This is a note for self to try to solve this issue.
In the lates release (9.0.0 rc2) the test target for make has been switched to the run of testasciidoc.py which causes issues in minimal build environments.

The 1st one is that it doesn't allow to change the CONF_DIR so testasciidoc try to pull the conf file from etc but this is not installed yet. A better solution is required.

Then there are other issues like source-highlight not found and other things like that.
I disabled the run of the tests in Debian for now but it would be nice to have a proper run later, hence this issue opened.

@MasterOdin
Copy link
Member

MasterOdin commented Apr 28, 2020

For the former, are you looking to change the CONF_DIR for testasciidoc.py uses for its data directory stuff or the CONF_DIR in asciidoc.py? For the later, would using the --attribute="asciidoc-confdir=/path/to/path" work for you? I admit I'm not totally sure how the recursive self subprocessing works with regards to those sorts of things in asciidoc.py.

For the latter, I can add a new directive to the testasciidoc.conf that looks something like:

% requires
['source-highlight']

where it's a list of strings and for each string, it checks if each element exists as a command on the filesystem (shutil.which(command)) and if not, skip the test.

@MasterOdin
Copy link
Member

There's also probably a broader question of is there any particular reason to not rewrite testasciidoc.py into something like pytest and not using this custom conf setup other than manpower required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants