Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

folding of properties/attributes #719

Open
maxandersen opened this issue Jun 3, 2023 · 1 comment · May be fixed by #733
Open

folding of properties/attributes #719

maxandersen opened this issue Jun 3, 2023 · 1 comment · May be fixed by #733
Assignees
@apupier
Labels
📂 area/text-folding 💬 discussion Disccussion on new features, projects, etc... ✨ enhancement 👶 good first 👋 help wanted
Milestone
3.0.0

Comments

@maxandersen
Copy link

would be great to collapse properties/attributes to remove "metadata noise".

Example from using asciidoctor reveal.js you have this block that you don't really need to see for normal editing:

[.blackback]
= Embracing a new thing :date: 2022-05-10
:revealjs_theme: white
:customcss: css/custom.css
:favicon: ./images/favicon.ico
// better 
:title-slide-background-image: images/blackspace.png
:slide-background-image: images/slide2-white.png
:revealjs_fragmentInURL: true
:revealjs_hash: true
:revealjs_controls: true
:revealjs_controlsLayout: edges
:revealjs_controlsTutorial: true
:revealjs_slideNumber: c/t
:revealjs_showSlideNumber: speaker
:revealjs_autoPlayMedia: true
:revealjs_totalTime: 2700
//:revealjs_parallaxBackgroundImage:  images/mntbackground.jpg
//:revealjs_parallaxBackgroundSize: 4936px 2092px
:source-highlighter: highlight.js
// leave empty or pick style from gallery at https://highlightjs.org/static/demo/ and find url at https://cdnjs.com/libraries/highlight.js
:highlightjs-theme: https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.5.1/styles/base16/solarized-dark.min.css
:revealjs_preloadIframes: true
:icons: font

Main text

would be nice to have that be:

   [.blackback]
   = Embracing Quarkus 3
> (attributes)

Main text
@maxandersen maxandersen added ✨ enhancement 💬 discussion Disccussion on new features, projects, etc... labels Jun 3, 2023
@ggrossetie
Copy link
Member

That's an excellent idea! 👍🏻

apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 16, 2023
@apupier
Provide folding range for sibling attributes
3743b96 
part of asciidoctor#719

basic use case covered, other cases to cover:
- include comment lines
- include emtpy lines

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 16, 2023
@apupier
Provide folding range for sibling attributes
01231e9 
part of asciidoctor#719

basic use case covered, other cases to cover:
- include comment lines
- include emtpy lines

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier mentioned this issue Jun 16, 2023
Merged
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 16, 2023
@apupier
Provide folding range for sibling attributes
828e3ce 
part of asciidoctor#719

basic use case covered, other cases potentially to cover:
- include comment lines
- include empty lines

Signed-off-by: Aurélien Pupier <[email protected]>
ggrossetie pushed a commit that referenced this issue Jun 17, 2023
@apupier
Provide folding range for sibling attributes (#723)
574e9f1 
part of #719

basic use case covered, other cases potentially to cover:
- include comment lines
- include empty lines

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 22, 2023
@apupier
Folding mix of Attributes and single-line comments
ddcbc2e 
It removes the possibility to have Folding range for the first group of
attributes or first group of single-line comments. This is due to a
limitation of VS Code which doesn't handle several folding ranges
starting on the same line.

resolves asciidoctor#719

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 23, 2023
@apupier
Folding mix of Attributes and single-line comments
a12d3cf 
It removes the possibility to have Folding range for the first group of
attributes or first group of single-line comments. This is due to a
limitation of VS Code which doesn't handle several folding ranges
starting on the same line.

resolves asciidoctor#719

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier linked a pull request Jun 23, 2023 that will close this issue
Open
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 23, 2023
@apupier
Folding mix of Attributes and single-line comments
f95b2fe 
It removes the possibility to have Folding range for the first group of
attributes or first group of single-line comments. This is due to a
limitation of VS Code which doesn't handle several folding ranges
starting on the same line.

resolves asciidoctor#719

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier self-assigned this Jun 23, 2023
@apupier apupier added this to the 3.0.0 milestone Jun 23, 2023
apupier added a commit to apupier/asciidoctor-vscode that referenced this issue Jun 23, 2023
@apupier
Folding mix of Attributes and single-line comments
d122d27 
It removes the possibility to have Folding range for the first group of
attributes or first group of single-line comments. This is due to a
limitation of VS Code which doesn't handle several folding ranges
starting on the same line.

resolves asciidoctor#719

Signed-off-by: Aurélien Pupier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apupier apupier

Labels
📂 area/text-folding 💬 discussion Disccussion on new features, projects, etc... ✨ enhancement 👶 good first 👋 help wanted
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Folding mix of Attributes and single-line comments apupier/asciidoctor-vscode
3 participants
@maxandersen @ggrossetie @apupier