fontawesome icons

[clojens]

I noticed quite a few icons were missing between the version used here and current font-awesome release. I hacked my local asciidoc-preview but I could do a pull request if you like. I just replaced all fonts/ and less/ contents of the folders - not knowing or caring about any tweaking you guys did and it works fine, just checking to make sure you didn't have any patched magic going on I wasn't aware of or if there was any other reason for not wanting to do a bump on fontawesome.

Cheers,
Rob

[mojavelinux]

No reason other than we just haven't upgraded yet. So let's do it!

We need to be sure to update it in core as well so it remains consistent. Could you file an issue there too? I'll schedule it for 1.5.2.

Are you aware of any incompatibilities between Font Awesome 4.2.0 and 4.1.0 (the current version we're using). If not, 👍

[clojens]

Nah seems all they did was add 40 new icons this time and no renames or anything, we should be fine. I'll take a closer look again and lookup the core repo to pull request there as well.

[mojavelinux]

This answers my question I asked in pull request in core, so it will make
it into 1.5.2!

[anthonny]

Wip

[clojens]

Oh right one more thing: may I suggest default non-italic icons?

[mojavelinux]

That seems like it's caused by a misconfiguration of the bundled stylesheet
since it should be handled by the default stylesheet.

[mojavelinux]

I'll have a look to see what's going on.

[anthonny]

Fixed

But i need to refactor and use the stylesheet factory, i will do it when i'll deal with #39

[mojavelinux]

Most excellent!

But i need to refactor and use the stylesheet factory, i will do it when i'll deal with #39

This is becoming a high priority for me, so let's put our heads together and get it done soon. I'm confident it will be a big win for the community.