Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Dockerfile to utilize buildkit's directory caching for much faster builds #413

Open
spkane opened this issue Jan 26, 2024 · 6 comments

Comments

@spkane
Copy link
Contributor

spkane commented Jan 26, 2024

This makes it possible to cache dep downloads from tools like apt, go get, gem, etc.

See: https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#run---mounttypecache

@dduportal
Copy link
Contributor

Good idea. Have you already used it in CI environments (i’m wondering how it would work with GitHub Actions ephemeral workers)

@spkane
Copy link
Contributor Author

spkane commented Jan 26, 2024

It would likely take some work to get it working well in the CI/CD pipeline. It would likely require either taking advantage of Github caching (https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflow) or getting Docker to store the cache somewhere remote, or some combination of the two.

That being said, it would improve the local workflow, no matter what. :-)

@Banane9
Copy link

Banane9 commented Jan 8, 2025

Was there any progress on this, or does the slow behavior I'm experiencing have another cause?

I've been using the (latest) docker image to build about 90kB worth of documentation that generates a ~100 page PDF document. This seems to take around 2 minutes each time when done through a docker run command, which is a far cry from the 100kB in one second claim on the Asciidoctor Docs page :(

@dduportal
Copy link
Contributor

Was there any progress on this, or does the slow behavior I'm experiencing have another cause?

I've been using the (latest) docker image to build about 90kB worth of documentation that generates a ~100 page PDF document. This seems to take around 2 minutes each time when done through a docker run command, which is a far cry from the 100kB in one second claim on the Asciidoctor Docs page :(

This is unrelated :) But it could be worth an issue: Do you mind opening a new one with more details?

@Banane9
Copy link

Banane9 commented Jan 8, 2025

This is unrelated :) But it could be worth an issue: Do you mind opening a new one with more details?

Sure, what details would be useful for you?

@dduportal
Copy link
Contributor

This is unrelated :) But it could be worth an issue: Do you mind opening a new one with more details?

Sure, what details would be useful for you?

The usual when you report an issue: environment, tools and their versions, reproduction case ideally, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants