deprecate ignore_implicit_conversion and implicit_conversion #1724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is work towards fixing #1723
This PR deprecates "implicit conversion" and the flag controlling warning messages when this behavior occurs (
ignore_implicit_conversion
). See the above issue for more details. In brief, this prevents extensions from adding support fornamedtuple
classes.The removal of this feature (after the deprecation period, which this PR will start) will mean that attempting to add a
namedtuple
to the asdf tree (without implementing a converter for thenamedtuple
) will result in an error. The effectively drops the "support" we currently have fornamedtuple
(which does not roundtrip, loses allnamedtuple
specifics and saves these instances as lists). User code that wishes to continue to supportnamedtuple
instances will need to:namedtuple
classes to allow roundtrippingChecklist: