Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure notebook, import, and fileattachment access #14

Open
5 tasks
asg017 opened this issue May 2, 2021 · 0 comments
Open
5 tasks

Secure notebook, import, and fileattachment access #14

asg017 opened this issue May 2, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@asg017
Copy link
Owner

asg017 commented May 2, 2021

Right now, anything can request from localhost:8080 and get data back, like source code, file attachments, etc.

We should tighten that up, so only the developer can access info.

dataflow run should open a webpage like http://localhost:8080?auth_token=65c87a64c6e5, where that auth token will authorize that user to view notebooks/get file attachments and all.

  • Don't connect to websocket unless valid auth token.
  • /api/import should also have some form of auth
  • /api/file-attachments should also have some auth
  • What about multiple clients? Not sure how jupyter handles this...
  • Toggle-able, let people expose a dev server if they really want to
@asg017 asg017 added the enhancement New feature or request label May 2, 2021
@asg017 asg017 added this to the v1 milestone May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant