From fcf81d54e09dd6271f0ae0536bc5ba9a01b16d61 Mon Sep 17 00:00:00 2001
From: skanderm <skanderm@gmail.com>
Date: Mon, 13 Nov 2023 10:59:03 -0800
Subject: [PATCH] fix: allow showing false values for boolean selects (#74)

---
 lib/ash_admin/components/resource/form.ex | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/lib/ash_admin/components/resource/form.ex b/lib/ash_admin/components/resource/form.ex
index 35cbe10..628f5d3 100644
--- a/lib/ash_admin/components/resource/form.ex
+++ b/lib/ash_admin/components/resource/form.ex
@@ -679,7 +679,8 @@ defmodule AshAdmin.Components.Resource.Form do
     <%= Phoenix.HTML.Form.select(
       @form,
       @attribute.name,
-      [Nil: nil, True: "true", False: "false"],
+      [True: "true", False: "false"]
+      |> Keyword.merge(if @attribute.allow_nil?, do: [Nil: nil], else: []),
       selected: value(@value, @form, @attribute),
       name: @name || @form.name <> "[#{@attribute.name}]"
     ) %>
@@ -1021,15 +1022,13 @@ defmodule AshAdmin.Components.Resource.Form do
 
   defp value({:value, value}, _, _), do: value
 
-  defp value(value, form, attribute) do
-    if value do
-      value
-    else
-      value = Phoenix.HTML.FormData.input_value(form.source, form, attribute.name)
+  defp value(value, _form, _attribute) when not is_nil(value), do: value
 
-      if value do
-        value
-      else
+  defp value(_value, form, attribute) do
+    value = Phoenix.HTML.FormData.input_value(form.source, form, attribute.name)
+
+    case value do
+      nil ->
         case attribute.default do
           nil ->
             nil
@@ -1040,7 +1039,9 @@ defmodule AshAdmin.Components.Resource.Form do
           default ->
             default
         end
-      end
+
+      value ->
+        value
     end
   end