Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default error handler should not be applied when a custom error handler is defined at domain level #260

Closed
ahey opened this issue Jan 15, 2025 · 0 comments · Fixed by #261
Closed

The default error handler should not be applied when a custom error handler is defined at domain level #260

ahey opened this issue Jan 15, 2025 · 0 comments · Fixed by #261
Labels
bug Something isn't working

Comments

@ahey
Copy link
Contributor

ahey commented Jan 15, 2025

The ability to specify an error handler at the resource level was recently added in this PR, a nice addition.

This introduced an unintended side-effect, such that when an error handler has been specified at the domain level, the default error handler was also being applied at the resource level.

I will submit a PR for this fix.
@ahey ahey added the bug Something isn't working label Jan 15, 2025
@ahey ahey mentioned this issue Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: default error handling ahey/ash_graphql
1 participant
@ahey