Custom :state attribute always returns error due to bug

[DriesCruyskens]

When a custom attribute for the state is defined:

state_machine do
  initial_states([:initial_state])
  default_initial_state(:initial_state)
  state_attribute(:state)
end

attributes do
  attribute :state, :string do
    allow_nil? false
    default :initial_state
    public? true
  end
end

The following error is thrown:

** (Spark.Error.DslError) [ResurrectRegistry.Credits.Credit]
attributes -> state:
  Expected the attribute state to have `default` set to :issued

Digging deeper I found that the default :initial_state attribute option arrives inside the transformer converted to a string:

attribute #=> %Ash.Resource.Attribute{
  name: :state,
  type: Ash.Type.String,
  allow_nil?: false,
....
  default: "issued",
...
}

And so the comparison attribute.default != default compares :initial_state with "initial_state" and always returns an error.

[zachdaniel]

Ah, good point. We should check that it's equal as an atom or as a string. Probably best to do to_string/1 on both before comparing. Would you be interested in PRing that fix?

[DriesCruyskens]

Will do soon!

[DriesCruyskens]

The problem was that I declared a state attribute myself, and that it had typed :string instead of :atom. This explains why the default value came back as string instead of an atom. I also assumed I had to create a custom attribute myself which turns out it wasn't necessary. I permitted myself to add this to the docs in #62.