Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Igniter.delete_file/2 #56

Open
ibarakaiev opened this issue Jul 18, 2024 · 1 comment
Open

Igniter.delete_file/2 #56

ibarakaiev opened this issue Jul 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ibarakaiev
Copy link
Contributor

Igniter currently lacks functionality to stage files for deletion. Note that Rewrite.delete/2 and Rewrite.drop/2 both remove the file from the list of sources but leave the actual files unaffected, whereas Rewrite.rm/2 deletes the file right away. So we need a custom way to track what files are about to be deleted, keeping in mind file moves, future possible re-adding files back, etc.

@ibarakaiev ibarakaiev added the enhancement New feature or request label Jul 18, 2024
@ibarakaiev
Copy link
Contributor Author

Note: if a file is deleted and its directory became empty, the directory should also probably be deleted (all the way up, until lib or test). Same should actually probably happen in igniter.move_files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant