You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context: updating Quick/Nimble/Nimble-Snapshots to the latest version coming from Quick 10.x
After adding @mainactor to our snapshot tests, all our snapshots tests were failing. When I rerecord the snapshots there's an extra underscore in the filename at the end, the actual snapshot is the same as before, the filename is not.
It seems that the name property on XCTActivity returns an extra colon which when processed causes the extra underscore. Still not quite sure why, since it's code from Apple that hasn't changed.
Behaviour with Quick 5.0.1, Nimble 10.0.0, Nimble-Snapshots 9.4.0:
Behaviour with Quick 6.1.0, Nimble 11.2.1, Nimble-Snapshots 9.5.1:
Since this hasn't been posted before, am I missing something obvious or could this be side-effect from switching to the new async approach in Quick?
The text was updated successfully, but these errors were encountered:
Sorry for the (very) delayed response. I think you're right that this is a side-effect of something, since the filenames are derived from the unit test names, which are themselves derived by Quick.
In these cases, I found it helpful to regenerate the screenshots entirely.
Context: updating Quick/Nimble/Nimble-Snapshots to the latest version coming from Quick 10.x
After adding @mainactor to our snapshot tests, all our snapshots tests were failing. When I rerecord the snapshots there's an extra underscore in the filename at the end, the actual snapshot is the same as before, the filename is not.
It seems that the name property on XCTActivity returns an extra colon which when processed causes the extra underscore. Still not quite sure why, since it's code from Apple that hasn't changed.
Behaviour with Quick 5.0.1, Nimble 10.0.0, Nimble-Snapshots 9.4.0:
Behaviour with Quick 6.1.0, Nimble 11.2.1, Nimble-Snapshots 9.5.1:
Since this hasn't been posted before, am I missing something obvious or could this be side-effect from switching to the new async approach in Quick?
The text was updated successfully, but these errors were encountered: