Support FailureDiffs without configuration #71
Conversation
| ``` | ||
| # Nimble-Snapshot | ||
| FailureDiffs | ||
| ``` |
There was a problem hiding this comment.
Nice, good job on the documentation 👍
There was a problem hiding this comment.
maybe this should be even more in evidence? I'd put it as a subitem of Use, before Dynamic Type
|
Ok so I have the same test failures locally, I let Travis confirmed that it wasn't simply a problem with my setup, like I didn't have my iPhone6 simulator running on 10.0 but 10.1 instead and that caused some of the output files to have the wrong path. I'll look into those failures. |
|
It's possible there are changes between 10.0 and 10.1 that caused the snapshot reference images to change. What do the diffs look like? We might just need to replace them with new ones. |
|
I haven't forgotten; I'm having a look tomorrow since it's Friday and I should be able to find the time 👍 |
|
Poke ^ :D |
|
Thanks for poking, I'll try to get this week |
|
Do your best, no pressure! And let us know if you need anything from our side. |
|
I'll reopen a new PR for this, I rebased on upstream but something got screwed up, and I know why now. |
This took an unexpected turn. There's a nice interface defined for the reference folder: https://github.com/facebook/ios-snapshot-test-case/blob/master/FBSnapshotTestCase/FBSnapshotTestController.h#L72 That's not the case for the failure diffs folder. I had to get creative so I used the setenv in order to give this failure diffs folder mapping by default. See here to know how it's used in the FBSnapshotTestCase project: https://github.com/facebook/ios-snapshot-test-case/blob/master/FBSnapshotTestCase/FBSnapshotTestController.m#L266-L268
|
All green now @ashfurrow |
|
I think something is not quite right: I've made the |
|
Ok @marcelofabri I'll see why and fix it. |
This took an unexpected turn. There's a nice interface defined for the
reference folder:
https://github.com/facebook/ios-snapshot-test-case/blob/master/FBSnapshotTestCase/FBSnapshotTestController.h#L72
That's not the case for the failure diffs folder. I had to get creative
so I used the setenv in order to give this failure diffs folder mapping
by default. See here to know how it's used in the FBSnapshotTestCase
project:
https://github.com/facebook/ios-snapshot-test-case/blob/master/FBSnapshotTestCase/FBSnapshotTestController.m#L266-L268
With all that said I'm still opening a PR cause I said I would and it was pretty straightforward but I won't feel bad if this gets rejected given the implementation I am submitting. I could take a further step and propose a change in
FBSnapshotTestCasebut I am not sure if I want to give that a shot.Ref: #68