From 9c8d764655cb8cb1f9a0890c349cbef98a9f53bc Mon Sep 17 00:00:00 2001 From: ashnamehrotra Date: Mon, 21 Aug 2023 18:19:35 +0000 Subject: [PATCH] lint fix --- controllers/imagejob/imagejob_controller.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/controllers/imagejob/imagejob_controller.go b/controllers/imagejob/imagejob_controller.go index f5d22c8d71..4e0af57b95 100644 --- a/controllers/imagejob/imagejob_controller.go +++ b/controllers/imagejob/imagejob_controller.go @@ -456,24 +456,24 @@ func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error { func podsComplete(podList []corev1.Pod) bool { for i := range podList { if podList[i].Status.Phase == corev1.PodRunning || podList[i].Status.Phase == corev1.PodPending { - if containersNotFailed(podList[i]) { - return false - } else { + if containersFailed(&podList[i]) { return true } + return false } } return true } -func containersNotFailed(pod corev1.Pod) bool { +func containersFailed(pod *corev1.Pod) bool { statuses := pod.Status.ContainerStatuses + log.Info("Statuses", "container statuses", statuses) for i := range statuses { if statuses[i].State.Terminated != nil { - return false + return true } } - return true + return false } func (r *Reconciler) updateJobStatus(ctx context.Context, imageJob *eraserv1.ImageJob) error {