Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test not finishing #110

Closed
maxulysse opened this issue Aug 28, 2023 · 7 comments
Closed

Test not finishing #110

maxulysse opened this issue Aug 28, 2023 · 7 comments
Labels

Comments

@maxulysse
Copy link

Hi,
I'm running this test https://github.com/nf-core/fetchngs/blob/57bf16705bf23fe2c7695774e2376f2c709a4d35/workflows/sra/tests/sra_skip_fastq_download.nf.test

It should be fairly similar to running this command nextflow run . -profile test,docker --outdir results -resume --skip_fastq_download, which takes less than a couple of minutes, but I can never seem to make it finish (cf https://github.com/nf-core/fetchngs/actions/runs/6000651325/job/16273188355?pr=191).

I did try some investigation on my machine but could not find out why the test would hang.
I had a look at the trace, and all tasks are completed.

Any idea where I can investigate more?

@lukfor
Copy link
Collaborator

lukfor commented Aug 28, 2023

Thanks, sounds related to #57 🤔

@maxulysse
Copy link
Author

indeed, it looks related, sorry I did not notice that issue.

@lukfor
Copy link
Collaborator

lukfor commented Aug 28, 2023

No worries. Good to have an other reproducible usecase! please let the issue open, so we know that it is critical for nf-core 👍

@lukfor lukfor added the nf-core label Aug 28, 2023
@maxulysse
Copy link
Author

Yeah, I'm really trying to fully replace the current tests we have with pytest by nf-test.
I do love this testing framework, just the snapshot possibilities are amazing.
Also, I really like how easy it is to test Nextflow at any level.

@lukfor
Copy link
Collaborator

lukfor commented Aug 30, 2023

PR #112 resolves issue #57. This PR should also address this issue. I'm leaving the issue open until we create a new release and confirm its resolution.

@lukfor
Copy link
Collaborator

lukfor commented Sep 8, 2023

We have just released RC1 of version 0.8.0 🎉
This is a pre-release and can be installed using the following command:

curl -fsSL https://code.askimed.com/install/nf-test | bash -s 0.8.0-rc1

If everything works as expected, please feel free to close this issue. Thanks for your support! 🙏

@maxulysse
Copy link
Author

works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants