Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-test with custom plugin gets killed halfway when asserting results #251

Closed
AlexVCaron opened this issue Aug 28, 2024 · 1 comment · Fixed by #264
Closed

nf-test with custom plugin gets killed halfway when asserting results #251

AlexVCaron opened this issue Aug 28, 2024 · 1 comment · Fixed by #264

Comments

@AlexVCaron
Copy link

I'm using a custom plugin with nf-test right now, to capture md5sum from complex data (Nifti-gz, it require a dedicated reader to get consistent md5 from the data inside the file). Nifti being a ND-image format, processing can get quite intensive and RAM can get filled before the Java garbage collector has time to pass.

I was wondeing why my tests tend to get killed halfway. Note I am working in a container and docker enforces resource limits, but I hadn't configured anything that could potentially go over those. Then I discovered the infamous line 54 in the nf-test executable, where there is a -Xmx10g, and I don't have that much RAM. I changed the value to a lower one - 6g in my case - and it works !

Now it's quite a pain to go and change that line everytime the executable changes. Would it be possible to add an option to set that value ? Or default to a standard java way of setting it like the JAVA_TOOL_OPTIONS or something ?

@lukfor
Copy link
Collaborator

lukfor commented Oct 9, 2024

Thanks. This issue has been fixed in PR #264 and will be available in the next update.

btw: are you interested in listing your nf-test plugin (https://github.com/scilus/nft-nifti) on the plugins page at https://plugins.nf-test.com/?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants