Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure proper range for depth range #161

Open
asl opened this issue Oct 9, 2024 · 0 comments · May be fixed by #172
Open

Ensure proper range for depth range #161

asl opened this issue Oct 9, 2024 · 0 comments · May be fixed by #172
Labels
good first issue Good for newcomers ui
Milestone
2024.08

Comments

@asl
Copy link
Owner

asl commented Oct 9, 2024

When graph drawing scope is "depth", then the depth node colorer should take these limits as well
@asl asl added good first issue Good for newcomers ui labels Oct 9, 2024
@asl asl added this to the 2024.08 milestone Oct 9, 2024
milenovic added a commit to milenovic/BandageNG that referenced this issue Jan 23, 2025
@milenovic
Ensure proper colorer range for depth range
7c716d5 
resolves asl#161
@milenovic milenovic linked a pull request Jan 23, 2025 that will close this issue
Open
milenovic added a commit to milenovic/BandageNG that referenced this issue Jan 23, 2025
@milenovic
Ensure proper colorer range for depth range
f9da80a 
resolves asl#161
milenovic added a commit to milenovic/BandageNG that referenced this issue Jan 24, 2025
@milenovic
Reimplement proper colorer range for depth range
e48430c 
When graph is redrawn, scope is passed to colorer which calculates low and high values and stores then for colorers to use when needed. Is this correct way to store them?
resolves asl#161
milenovic added a commit to milenovic/BandageNG that referenced this issue Jan 25, 2025
@milenovic
Save scope reference in DepthNodeColorer
94e08df 
Store Scope reference when graph is redrawn. Scope reference is stored only in a private static variable of DepthNodeColorer, which persists when colorers are changed.
As DepthNodeColorer instance might not exist when scope is changed, reference is saved by a function defined in INodeColorer.
resolves asl#161
milenovic added a commit to milenovic/BandageNG that referenced this issue Jan 26, 2025
@milenovic
Dynamic implementation of proper range for depth node colorer
91f7cf2 
resolves asl#161
milenovic added a commit to milenovic/BandageNG that referenced this issue Jan 26, 2025
@milenovic
Fix failed linux tests
116882a 
fixes asl#161 build errors
milenovic added a commit to milenovic/BandageNG that referenced this issue Jan 26, 2025
@milenovic
Install imagemagick on Linux before running tests
c31a7f9 
Ubuntu >24.04 image does not longer include imagemagick by default.
fixes asl#161 Linux tests fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ui
Projects
None yet
Milestone
2024.08
Development

Successfully merging a pull request may close this issue.

Ensure proper colorer range for depth range milenovic/BandageNG
1 participant
@asl