Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete ROAs? #20

Open
job opened this issue Sep 5, 2024 · 1 comment
Open

Incomplete ROAs? #20

job opened this issue Sep 5, 2024 · 1 comment

Comments

@job
Copy link

job commented Sep 5, 2024

What does this comment mean? https://github.com/fjahr/kartograf/blob/37947d4611230985da39ae18db535f56af01ec8e/kartograf/rpki/parse.py#L31

@fjahr
Copy link
Collaborator

fjahr commented Sep 23, 2024

@job Sorry for the late response! At some point early on I encountered cases where one of the keys that I needed were missing in the result. I don't remember which key it was specifically, it wasn't all of them probably just one. I just added this safe guard afterwards to make sure I we would run into issues in the future. I don't think I have can say which key it was that was missing because I added this very early on when I was just trying to see if it was even possible to make it work. We need to add better detailed logging for debugging, so I we can add this as one of the things to include there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants