-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Some packages rely on site-packages layout #274
Comments
I gave some thought to it, and I think making a symlink forest inside the venv will be the right way to do this. |
Yes, and it's very similar to what @thesayyn has been working on in rules_oci where those symlinks point outside of that folder to other entries in bazel-out - we'll get his help to fix this. |
I threw together something in a PR because my team needed it sooner. Please feel free to reject it. |
@mattem could you take a look at that PR? |
This emulates the behavior where a single site-packages directory contains all/most PyPi packages. Packages distributed by NVIDIA currently assume this through the use of rpath as `$ORIGIN/../../` to reach the `nvidia` package location. Downstream libraries like torch and jax do not set up the dynamic library search path based on sys.path either. Fixes #274. --------- Co-authored-by: Matt Mackay <[email protected]>
What happened?
rules_py doesn't really create a standard
pip install
-stylesite-packages
folder currently, rather it creates a.pth
file and expects packages to "do the right thing".This plays badly with loading shared objects in particular, such as
Version
HEAD
How to reproduce
No response
Any other information?
No response
The text was updated successfully, but these errors were encountered: