Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Under bzlmod, always builds rust binaries from source #290

Closed
alexeagle opened this issue Mar 2, 2024 · 0 comments · Fixed by #292
Closed

[Bug]: Under bzlmod, always builds rust binaries from source #290

alexeagle opened this issue Mar 2, 2024 · 0 comments · Fixed by #292
Assignees
@alexeagle
Labels
bug Something isn't working untriaged Requires traige

Comments

@alexeagle
Copy link
Member

What happened?

Followup to #287 which added conditional logic for WORKSPACE users to download pre-built binaries instead, and register them in the toolchain.

Version

HEAD

How to reproduce

No response

Any other information?

No response
@alexeagle alexeagle added the bug Something isn't working label Mar 2, 2024
@alexeagle alexeagle self-assigned this Mar 2, 2024
@github-actions github-actions bot added the untriaged Requires traige label Mar 2, 2024
@alexeagle alexeagle mentioned this issue Mar 2, 2024
Merged
alexeagle added a commit that referenced this issue Mar 2, 2024
@alexeagle
Publish binaries on releases (#292)
9ee2b08 
Fixes #290 
Fixes #289 

---

### Type of change

- Bug fix (change which fixes an issue)

### Test plan

- Covered by existing test cases
- Manual testing; please provide instructions so we can reproduce:
@github-project-automation github-project-automation bot moved this to ✅ Done in Open Source Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
bug Something isn't working untriaged Requires traige
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish binaries on releases aspect-build/rules_py
1 participant
@alexeagle