Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: venv symlink creation can run into collisions #335

Closed
vors opened this issue Apr 29, 2024 · 2 comments · Fixed by #336
Closed

[Bug]: venv symlink creation can run into collisions #335

vors opened this issue Apr 29, 2024 · 2 comments · Fixed by #336
Assignees
Labels
bug Something isn't working

Comments

@vors
Copy link

vors commented Apr 29, 2024

What happened?

If there are wheels who define the same files then venv creation will fail.
Sometimes this is desirable, but often collision is on something silly like CHANGELOG.md and it would be good to somehow allow such problem to resolve without patching wheels

Repro #334

Version

Development (host) and target OS/architectures:

Output of bazel --version:

bazel 7.0.2

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

0.7.2

Language(s) and/or frameworks involved:

How to reproduce

https://github.com/aspect-build/rules_py/pull/334

Any other information?

No response

@vors vors added the bug Something isn't working label Apr 29, 2024
@github-actions github-actions bot added the untriaged Requires traige label Apr 29, 2024
@mattem mattem removed the untriaged Requires traige label Apr 29, 2024
@mattem mattem self-assigned this Apr 29, 2024
@mattem
Copy link
Contributor

mattem commented Apr 29, 2024

Fun. Files at the wheel root, even outside of pure and plat lib, are allowed. pip seems to let the last one win when I tried it manually. Do other package managers warn or do the same thing?

@vors
Copy link
Author

vors commented Apr 29, 2024

I only used pip extensively... never saw any warnings from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants