fix: propagate target_compatible_with to _py_env when creating a …
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test or binary python target
|
|
mattem
reviewed
Nov 19, 2024
py/defs.bzl
Outdated
| @@ -90,6 +90,7 @@ def _py_binary_or_test(name, rule, srcs, main, deps = [], resolutions = {}, **kw | |||
| package_collisions = package_collisions, | |||
| tags = ["manual"], | |||
| testonly = kwargs.get("testonly", False), | |||
| target_compatible_with = kwargs.get("target_compatible_with", False), | |||
There was a problem hiding this comment.
I think we want the default here to either be [] or None.
There was a problem hiding this comment.
yes! I copied from the line above and missed that thanks
|
Thanks, are you able to sign the CLA? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This fixes #437.
This is my first issue so I'm not sure if this is the right thing to do.
Tell me if this is good or you want me to change anything :)