Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Setting transitive dependencies as virtual #439

Open
bd-jahn opened this issue Nov 16, 2024 · 1 comment
Open

[FR]: Setting transitive dependencies as virtual #439

bd-jahn opened this issue Nov 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bd-jahn
Copy link

bd-jahn commented Nov 16, 2024

What is the current behavior?

Let's say I have a library foo that depends on bar and baz, and I want to replace bar and baz with my custom packages.
The current behavior doesn’t completely replace bar and baz with my custom packages; instead, it appends them to the transitively introduced bar and baz.

py_library(
    name = "libfoo",
    srcs = [...],
    deps = [requirement("foo")],
    virtual_deps = [
        "bar",
        "baz",
    ],
)

py_binary(
    name = "main",
    srcs = ["main.py"],
    resolutions = foo_resolutions.override({
        "bar": "<path_to_bar_wheel>",
        "baz": "<path_to_baz_wheel>",
    }),
    deps = [":libfoo"],
)

Describe the feature

In the above example, I want to create a venv with foo, but using my custom bar and baz.

@bd-jahn bd-jahn added the enhancement New feature or request label Nov 16, 2024
@alexeagle
Copy link
Member

@mattem you know this feature the best, do you have an idea of whether this is feasible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants