Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy #235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mypy #235

wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Dec 22, 2023

Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Relevant documentation has been updated

Test plan

  • New test cases added

In a follow-up change I'll try to empty out the WORKSPACE file.
Enable it for this repo, so we have to make our code type-check.
@tymur-l
Copy link

tymur-l commented Feb 19, 2024

It would be really nice to have this feature, so that people can easily adopt mypy for python projects built with recent versions of bazel :)

I am relatively new to bazel, but I would be happy to contribute to this feature. Is there anything I can do to make progress on merging it?

@alexeagle
Copy link
Member Author

Hi @Sitiritis - thanks for asking, the likely course right now is to fix up https://github.com/bazel-contrib/bazel-mypy-integration since there's an enthusiastic contributor helping out there now. I'll have to figure out whether the rules_py virtualenv setup is related to running mypy, but for now it will just work with rules_python.

@tymur-l
Copy link

tymur-l commented Feb 19, 2024

Hi @Sitiritis - thanks for asking, the likely course right now is to fix up https://github.com/bazel-contrib/bazel-mypy-integration since there's an enthusiastic contributor helping out there now. I'll have to figure out whether the rules_py virtualenv setup is related to running mypy, but for now it will just work with rules_python.

@alexeagle, thank you for the response, sounds great!

chrisirhc added a commit to chrisirhc/bazel-mypy-integration that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants