Revert "Add types to file generated by __test__.py" #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 509ed22.
thesayyn
approved these changes
Nov 13, 2024
|
@mattem In case you still want to have typing and support older Python versions (although they might be EOL already), you could use from typing import List
# some code
user_args: List[str] = [$$FLAGS$$] |
mattem
pushed a commit
that referenced
this pull request
Nov 19, 2024
As suggested in #435 (comment) a backwards compatible (< Python 3.9) type hint. Regardless of merging this PR or not, the current 1.0.0 release is broken for < Python 3.9. Since Python 3.8 is already EOL, this is in theory valid, but I guess there are still a few people using Python 3.8 because of Ubuntu 20.04. --- ### Changes are visible to end-users: no ### Test plan <!-- Delete any which do not apply --> - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #428
Revert as it's causing a failure on CI for older versions of Python.