Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose uvicorn's uds option to bind to a UNIX domain socket #67

Open
mvelbaum opened this issue Sep 8, 2024 · 2 comments
Open

Expose uvicorn's uds option to bind to a UNIX domain socket #67

mvelbaum opened this issue Sep 8, 2024 · 2 comments

Comments

@mvelbaum
Copy link

mvelbaum commented Sep 8, 2024

Hi,

Uvicorn supports binding to a UNIX domain socket via the uds option but asphalt-web does not expose it.

Is it possible to expose this?

Thanks!

@mvelbaum mvelbaum changed the title Expose uvicorn's --uds option to bind to a UNIX domain socket Expose uvicorn's uds option to bind to a UNIX domain socket Sep 8, 2024
@agronholm
Copy link
Member

In the upcoming major release (Asphalt 5), I've changed asphalt-web to use hypercorn instead of uvicorn because the latter does not support Trio. Check out the asphalt5 branch to see for yourself. If your request is still valid for hypercorn, I am favorable to adding it.

@mvelbaum
Copy link
Author

mvelbaum commented Sep 9, 2024

Looks like hypercorn supports it by specifying a bind address with unix: prefix: https://hypercorn.readthedocs.io/en/latest/how_to_guides/binds.html

So maybe you won't even have to do anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants