Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin should autoupdate #240

Open
1 task done
asirota opened this issue Dec 4, 2024 · 2 comments
Open
1 task done

Plugin should autoupdate #240

asirota opened this issue Dec 4, 2024 · 2 comments
Labels
enhancement New feature or request needs triage needs to be discussed and worked on
Milestone

Comments

@asirota
Copy link
Member

asirota commented Dec 4, 2024

I have checked the following:

  • I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add

To mitigate faulty operation the AU plugin must autoupdate from a known high uptime AspireCloud repository (the one run by AspirePress?). Changes in protocol, emergency break fix and other "acts of G-d" could require an emergency update and all sites running AU need to quickly update. The Must-Use feature (#136) could also be related to this request.

Mockups or Images of the feature

none yet, but in theory a mockup could show a notice on dashboard that shows that AU is out of date, maybe support for an emergency banner showing out of date status with a link to update (if auto-update failed somehow).

@asirota asirota added enhancement New feature or request needs triage needs to be discussed and worked on labels Dec 4, 2024
@costdev
Copy link
Contributor

costdev commented Dec 4, 2024

I suggest that we avoid the need to force the "main" AspirePress repository for AspireUpdate updates so that we can completely decouple updates from AspireCloud/AspireSync operation.

Instead, we can leverage our existing Git Updater integration along with also integrating Git Updater Lite. This means update checks of 6 hours rather than WordPress Core's default of 12 hours, and will reduce overhead on client sites as they won't need to have Git Updater installed.

What this means in actionable terms:

  1. Install Git Updater 12.7 or later on the main website.
  2. Integrate AspireUpdate with Git Updater Lite. This means a very small Composer library and ~2 lines of code in AspireUpdate to integrate it.
  3. Install AspireUpdate on the main website. It doesn't even need to be active.

The main website then becomes our update server, with GitHub being our asset host. Each time we issue a new tagged release from this repository, an update will be displayed on all client websites within 6 hours to install that tagged release.

@afragen What do you think?

@afragen
Copy link
Contributor

afragen commented Dec 4, 2024

It would certainly work. @asirota , if you want a PR it’s pretty simple.

Is Git Updater installed on aspirepress.org? That would be the other piece.

@costdev costdev added this to the Phase 1 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage needs to be discussed and worked on
Projects
None yet
Development

No branches or pull requests

3 participants