Skip to content
This repository has been archived by the owner on Dec 16, 2023. It is now read-only.

Support for new Option constructor #975

Open
cammellos opened this issue Nov 23, 2015 · 6 comments
Open

Support for new Option constructor #975

cammellos opened this issue Nov 23, 2015 · 6 comments

Comments

@cammellos
Copy link

Hi,
I am loading a javascript library that uses this code:
new Option(....)

it works fine on the browser, but zombies is throwing an error:

ReferenceError: Option is not defined

Is there anything we can do?
Thanks for the library

@bitdivine
Copy link

It looks as if Option is defined in node_modules/commander/index.js . What eludes me is how that is loaded into the "browser".

@bitdivine
Copy link

Never mind, commander seems to be unrelated :-/

@TerjeBr
Copy link

TerjeBr commented Sep 14, 2017

This is a bug in jsdom, see jsdom/jsdom#1759

To fix this zombie needs to use a version of jsdom later than 9.12.0

@TerjeBr
Copy link

TerjeBr commented Mar 13, 2018

@assaf Any plans to do anything about this? Will you release a version with a newer jsdom soon?

@assaf
Copy link
Owner

assaf commented Mar 21, 2018

There's a PR in progress for upgrading to JSDOM 11.5.1: #1153

@TerjeBr
Copy link

TerjeBr commented Mar 21, 2018

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants