Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tokio::process::Command #224

Open
nickpdemarco opened this issue Nov 14, 2024 · 1 comment
Open

Support for tokio::process::Command #224

nickpdemarco opened this issue Nov 14, 2024 · 1 comment

Comments

@nickpdemarco
Copy link

After hitting this issue I tried to add basic support for tokio::process::command in #223. I was asked to raise an issue here to discuss whether this is desirable and, if so, how best to proceed.

@epage
Copy link
Contributor

epage commented Dec 13, 2024

Looks like all of the building blocks are present for tokio::process::command to work, this would just be about providing convenience functions for it.

My own personal biases

  • I tend to keep things small, simple by not providing integrations with other libraries in my crates
  • I tend to avoid touching async as I have no use cases for it which both makes me shy away from async contributions and makes it harder to evaluate them
  • I've been tempted to deprecate assert_cmd in favor of snapbox but then we'll just have the conversation over there :)

I've been going back and forth on whether to move forward with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants