From 9d15e5316342d6b729664fb73495a6f07fb33b1b Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Thu, 5 Dec 2024 01:58:30 +0100 Subject: [PATCH] misc fixes for shared build --- velox/dwio/dwrf/test/utils/CMakeLists.txt | 1 + velox/flag_definitions/CMakeLists.txt | 2 +- velox/tool/trace/CMakeLists.txt | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/velox/dwio/dwrf/test/utils/CMakeLists.txt b/velox/dwio/dwrf/test/utils/CMakeLists.txt index 89bfc2e4fdf9..16f035f7670a 100644 --- a/velox/dwio/dwrf/test/utils/CMakeLists.txt +++ b/velox/dwio/dwrf/test/utils/CMakeLists.txt @@ -20,6 +20,7 @@ target_link_libraries( velox_dwio_common velox_dwio_common_exception velox_dwio_dwrf_reader + velox_dwio_common_test_utils velox_dwio_dwrf_writer velox_exception velox_memory diff --git a/velox/flag_definitions/CMakeLists.txt b/velox/flag_definitions/CMakeLists.txt index 8569cc3f997d..8b551113d735 100644 --- a/velox/flag_definitions/CMakeLists.txt +++ b/velox/flag_definitions/CMakeLists.txt @@ -11,5 +11,5 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -velox_add_library(velox_flag_definitions OBJECT flags.cpp) +velox_add_library(velox_flag_definitions flags.cpp) velox_link_libraries(velox_flag_definitions PRIVATE gflags::gflags) diff --git a/velox/tool/trace/CMakeLists.txt b/velox/tool/trace/CMakeLists.txt index d179b26c340e..d36ee8fab023 100644 --- a/velox/tool/trace/CMakeLists.txt +++ b/velox/tool/trace/CMakeLists.txt @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -velox_add_library( +add_library( velox_query_trace_replayer_base AggregationReplayer.cpp FilterProjectReplayer.cpp @@ -23,7 +23,7 @@ velox_add_library( TableWriterReplayer.cpp TraceReplayRunner.cpp) -velox_link_libraries( +target_link_libraries( velox_query_trace_replayer_base velox_aggregates velox_type