Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox support #4

Open
ariesclark opened this issue Oct 16, 2024 · 6 comments
Open

Firefox support #4

ariesclark opened this issue Oct 16, 2024 · 6 comments

Comments

@ariesclark
Copy link
Contributor

ariesclark commented Oct 16, 2024

The extension seems to support Firefox, but isn't published on https://addons.mozilla.org/en-CA/firefox/extensions/.

@astahmer
Copy link
Owner

working on it!

image

@astahmer
Copy link
Owner

done & publlished here !
I noticed a bunch of stuff breaking initially due to different behaviour between chromium & firefox, those are mostly fixed but you might still encounter a random issue as I didnt test it as much as the chrome version

one thing I noticed wasn't working at all (that I did not invest time into fixing) is the inline adding of styles, stuff like color: red in this screenshot:
image
as a temporary solution, I just removed this feature entirely for the Firefox version, I'm open to PRs if someone wants to fix it

@astahmer
Copy link
Owner

actually; re-opening for a few days so that people can see the link to the extension

@astahmer astahmer reopened this Oct 17, 2024
@thisisjamessmith
Copy link

thisisjamessmith commented Oct 17, 2024

Thanks for this! Giving it a whirl. There's an intermittent console error at the moment:
Error: [webext-bridge] No handler registered in 'devtools' to accept messages with id 'focus'

@astahmer
Copy link
Owner

ah, sorry about that !

I had this issue at some point yesterday but restarting the devtools fixed it and couldnt reproduce afterwards so I thought this was a dev-only thing, especially since it was working fine for me in prod (https://x.com/astahmer_dev/status/1846891507044794657)

would you like to send a PR ?

@thisisjamessmith
Copy link

I wish I could! Sadly I have zero experience of building browser extensions, wouldn't know where to start!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants