Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros: AT MA KW \;;CR; not clicking with right mouse button #28

Open
klues opened this issue Jul 14, 2021 · 5 comments
Open

Macros: AT MA KW \;;CR; not clicking with right mouse button #28

klues opened this issue Jul 14, 2021 · 5 comments

Comments

@klues
Copy link
Contributor

klues commented Jul 14, 2021

I'm testing macro function via serial console AT MA KW \;;CR;:

  1. Writes ; as expected
  2. Doesn't do a right-click with the mouse as expected.
@ChrisVeigl
Copy link
Contributor

hmmm - what happens instead of the right-click?
did you try other commands/combinations?
does it work if you use KW with a normal character sequence (without escape characters)?

@klues
Copy link
Contributor Author

klues commented Jul 15, 2021

Seems like in all cases only the first command executes:

  • AT MA KW a;WA 500;KW b - only a is written
  • AT CR;WA 500;KW b - only right mouse click
  • AT MA KW b;KW a - only b is written

@ChrisVeigl
Copy link
Contributor

ok ... then there is definitely something wrong ...
probably i introduced a bug with this commit: a68b3ba

the purpose was to allow an optional string parameter (e.g. for AT DE)
i suppose that this does not work when the larger parameter string for the MA command is chopped during processing of each individual command (in commands.cpp) - sorry that i did not test MA sufficiently ...

that part of the code is quite obfuscated anyhow ...
i currently have no access to HW for testing, so it could take me a while to actually fix that.

@klues
Copy link
Contributor Author

klues commented Jul 15, 2021

I think there's no hurry to fix it - now first enjoy your holiday 🌞

@ChrisVeigl
Copy link
Contributor

after long holidays, this should be fixed with
028029e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants