Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform automatic diffs for pull requests #461

Open
zanieb opened this issue Dec 30, 2024 · 1 comment
Open

Perform automatic diffs for pull requests #461

zanieb opened this issue Dec 30, 2024 · 1 comment
Labels
internal A refactor or improvement that is not user-facing

Comments

@zanieb
Copy link
Member

zanieb commented Dec 30, 2024

As described in #460 (comment)

It'd be great to post a summary of changes to distributions on pull requests.

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Dec 30, 2024
@indygreg
Copy link
Collaborator

Most bang for your buck is diffing the PYTHON.json file, as it encapsulates the most important bits, including the Python autoconf variables. Next most useful thing is the set of files whose content changed. Builds are highly deterministic. (And it should be possible to close remaining determinism gaps pretty easily to reduce noise.) So the changed files set should be pretty small for most PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

No branches or pull requests

2 participants