Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow 3.0 deprecations #14626

Open
dhruvmanila opened this issue Nov 27, 2024 · 5 comments
Open

Airflow 3.0 deprecations #14626

dhruvmanila opened this issue Nov 27, 2024 · 5 comments
Labels
rule Implementing or modifying a lint rule

Comments

@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 27, 2024

Tracking issue for the AIR3xx rules that implements Airflow 3.0 deprecations.

For details, refer to the Airflow tracking issue: apache/airflow#44556

Ref: apache/airflow#41641

@Lee-W
Copy link

Lee-W commented Nov 28, 2024

There's already a short proposal #14616 (comment). Putting it here might make it easier to find 🙂


I'm thinking of separating "removal" and "rename" at least. It would be much easier for the users to know whether there's anything they could do to fix it.

@dhruvmanila
Copy link
Member Author

Additionally, the NumPy 2.0 migration rule is a good reference whose implementation is at: https://github.com/astral-sh/ruff/blob/6f1cf5b686e67fb74383641fcbbe98e33481a271/crates/ruff_linter/src/rules/numpy/rules/numpy_2_0_deprecation.rs

@Lee-W
Copy link

Lee-W commented Nov 29, 2024

Hi, we have grouped our deprecations into several categories and would appreciate it if the team could take a look and let us know what you think about it 🙂

Here's the categorised list we have now
apache/airflow#41641 (comment)
(there's another group we temporarily mark as AIR305, but we'll need some time to figure out what we can do for those. Will likely to be merged into 302 or 303)

@MichaReiser
Copy link
Member

I like what's proposed here. Thanks for going through all the deprecations and grouping them by possible rules. We can also do some fine-tuning as we go.

@Lee-W
Copy link

Lee-W commented Dec 3, 2024

Later discuss with @uranusjr, we think it would be better for us to merge rename and removal into 302. So the current idea would be

We now use apache/airflow#44556 to track the detail of this task instead of the original one as some of the migration might not be able to be done in ruff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

No branches or pull requests

3 participants