Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild on uv.lock, not pyproject.toml #34

Open
juliancoffee opened this issue Dec 16, 2024 · 3 comments
Open

Rebuild on uv.lock, not pyproject.toml #34

juliancoffee opened this issue Dec 16, 2024 · 3 comments
Labels
help wanted Contribution especially encouraged

Comments

@juliancoffee
Copy link

I was just trying the new docker compose --watch feature and I get why we would want to rebuild on pyproject.toml, because, well, that's where dependencies live, but pyproject.toml contains a lot of other stuff nowadays, like lint rules (for ruff of course 😉 ), it feels counter-productive to rebuild on it.

But maybe it's just me, I'm not sure.
Anyway, I'm not sure, if that's the place for it but I just wanted to say thank you! I'm surprised at how great this example is, with splitting installs for better caching and all that.

@zanieb
Copy link
Member

zanieb commented Dec 16, 2024

That seems reasonable to me! Especially since we do a --frozen sync.

Glad to hear the example is helpful!

@zanieb zanieb added the help wanted Contribution especially encouraged label Dec 16, 2024
@juliancoffee
Copy link
Author

juliancoffee commented Dec 17, 2024

I could make a quick PR

@zanieb
Copy link
Member

zanieb commented Dec 17, 2024

@juliancoffee please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contribution especially encouraged
Projects
None yet
Development

No branches or pull requests

2 participants