Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement blocking retry logic in sequencer startup for initial attempt to fetch oracle data #1787

Closed
Fraser999 opened this issue Nov 4, 2024 · 1 comment
Closed

Implement blocking retry logic in sequencer startup for initial attempt to fetch oracle data #1787

Fraser999 opened this issue Nov 4, 2024 · 1 comment
Assignees
@Fraser999

Comments

@Fraser999
Copy link
Contributor

Fraser999 commented Nov 4, 2024 •
edited by sync-by-unito bot
Loading

Change the initial attempt to retrieve data from the Connect oracle service so that:

  • it retries as per other similar retry strategies
  • it blocks until success or until a hard-coded timeout
  • if timeout, execute graceful shutdown

┆Issue Number: ENG-996
@Fraser999 Fraser999 mentioned this issue Nov 5, 2024
Merged
noot added a commit that referenced this issue Nov 7, 2024
@Fraser999 @noot @SuperFluffy
chore(sequencer): implement retry logic for connecting to the oracle …
1b162c2 
…sidecar (#1788)

## Summary
This changes sequencer initialization to be blocked while attempting to
connect to the oracle sidecar (if configured to use the sidecar), and to
fail if repeated connection attempts fail.

## Background
This was a todo in the code.

## Changes
- Added blocking retry logic around creating a connected oracle client.

## Testing
Added a unit test to confirm the process waits for the expected
duration. We could probably do with adding gRPC mock tests for the
sidecar, but I think that's outside the scope of this PR.

## Changelogs
No updates required as this is (effectively) a feature branch which will
have all relevant changelogs updated as one of the final steps of
completing the feature.

## Related Issues
Closes #1787

---------

Co-authored-by: elizabeth <[email protected]>
Co-authored-by: Richard Janis Goldschmidt <[email protected]>
@Fraser999
Copy link
Contributor Author

Closed via #1788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fraser999 Fraser999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fraser999