Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries for 5xx errors on astro deploy #1722

Open
neel-astro opened this issue Sep 23, 2024 · 1 comment
Open

Add retries for 5xx errors on astro deploy #1722

neel-astro opened this issue Sep 23, 2024 · 1 comment

Comments

@neel-astro
Copy link
Contributor

neel-astro commented Sep 23, 2024

When deploying images to the registry, sometimes there are 5xx errors returned from the registry for various reasons which are mostly intermittent, Astro CLI should look to retry with a small delay on such errors.

Look into whether such retries must be configurable, enabled, or disabled by default when working on the issue.

Also check out if the error could be captured and if we could return a meaningful error instead of exit code 1, in our retry messages

Slack conversation: https://astronomer.slack.com/archives/CL44PA4DB/p1726738192456099

@neel-astro
Copy link
Contributor Author

TODO: investigate how to capture the error from push command cleanly for both docker & podman engine, and define the errors when we want to retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant